-
Notifications
You must be signed in to change notification settings - Fork 181
Update the extension examples repo to use the latest extension template #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you @krassowski! |
Don´t bother starting the CI ... I have some new failures in my test version too... 🤔 |
I have fixed |
I guess this is the issue for |
Looking at
![]() extension-examples/kernel-output/ui-tests/tests/kernel-output.spec.ts Lines 29 to 32 in 4585387
I suspect the ![]() I think we would need something like: const select = page.locator('.jp-Dialog-body').locator('select');
const optionLocator = select.locator('option', { hasText: /Untitled.ipynb.*/ });
const value = await optionLocator.getAttribute('value');
await page.locator('.jp-Dialog-body').locator('select').selectOption({ value }); |
mimerenderer/ui-tests/tests/jupyterlab_examples_mimerenderer.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cmarmo!
Well thank you @krassowski for your patience and your help! |
Thank you @cmarmo and @krassowski, super cool to see the repo updated and the CI back to green! |
Dear maintainers,
this pull request updates the extension examples to the latest extension template.
I tried to create one commit per example as I feel it could make the review easier, don't hesitate to squash the commits if this PR is merged.
Hopefully this update will solve the failing CI in #279
Thank you for your attention.